Support for IAMF boxes and dumping headers#480
Merged
Conversation
Closed
Collaborator
|
@Luiz-Monad The change in test coverage parameters and a rebase did not help. Analysis: The iamf package (parser and types) is the biggest coverage gap in this PR. |
- Lowercase error strings for ST1005 (staticcheck) - Wrap long paramParse signature for lll (140-char limit) - Fix infinite recursion in ObuReader.Context - Add TableIndex to expanded() so descriptions resolve correctly - Drop unused ctx parameter from scalableChannelLayoutConfig - Fix AacDecoderConfig: SampleRate was set on error path; now set on success - Remove unused GetCodecString stub - Add iamf_test.go covering Leb128, Rational, signExtend, codec configs, ObuReader, channel layout descriptions, and enum String() methods
… header Adds direct tests for codecConfigObu (PCM/FLAC/AAC/unknown/duplicate-ID/ zero-samples), audioElementObu (ambisonics mono and projection, duplicate ID, missing codec config), parseObuSR trimming/extension branches, all SoundSystem enum variants and all PCM bit/format combinations.
Adds direct tests for paramParse: demixing subblocks (verifies DefaultW extraction), recon gain, variable subblock durations, and parameter reuse by existing parameterID. Also tests audioElementObu rejection of unknown audio element types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used the Opus as reference to implement IAMF.
. implemented the missing IACB and IAMF boxes
. implemented the parser for the IAMF headers based on FFMPEG
. implemented the dumper for IAMF structures so we can debug
. test with a real file from the AOMedia foundation samples