Skip to content

Restructure extensions v2 and resolve the findings it surfaced - #189

Merged
admdly merged 12 commits into
mainfrom
refactor/ext-v2-cleanup
Aug 6, 2026
Merged

Restructure extensions v2 and resolve the findings it surfaced#189
admdly merged 12 commits into
mainfrom
refactor/ext-v2-cleanup

Conversation

@admdly

@admdly admdly commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Restructures src/services/extensions/v2 from 21 flat files into a layered layout, then works through the reuse/efficiency/correctness findings that fell out of it. Establishes v2 as the reference shape for larger services and documents it.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 6, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
api 0de98c4 Commit Preview URL

Branch Preview URL
Aug 06 2026, 08:52 PM

@admdly admdly self-assigned this Aug 6, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 52 files

Not reviewed (too large): test/services/extensions/v2/index.test.ts (~5,084 lines) - if these are generated or fixture files, add them to ignored paths to exclude them from future reviews.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/services/extensions/v2/schemas/extensions.ts
Comment thread src/services/extensions/v2/schemas/developers.ts
Comment thread src/services/extensions/v2/github/verification.ts
Comment thread src/services/extensions/v2/schemas/ownership.ts
Comment thread package.json Outdated
Comment thread src/services/extensions/v2/schemas/submissions.ts
Comment thread src/services/extensions/v2/db/cursor.ts Outdated
Comment thread test/services/extensions/v2/ownership.test.ts

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 16 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/services/extensions/v2/schemas/ownership.ts Outdated
Comment thread src/services/extensions/v2/schemas/ownership.ts
Comment thread src/services/extensions/v2/README.md Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 8 files (changes from recent commits).

Requires human review: Auto-approval blocked by 4 unresolved issues from previous reviews.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 5 files (changes from recent commits).

Requires human review: Auto-approval blocked by 4 unresolved issues from previous reviews.

Re-trigger cubic

@admdly
admdly merged commit ff81540 into main Aug 6, 2026
3 checks passed
@admdly
admdly deleted the refactor/ext-v2-cleanup branch August 6, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant