Fix #106: preserve nullable bit when setting SQL_TEXT in _php_ibase_b…#110
Open
MartinKoeditz wants to merge 1 commit intomasterfrom
Open
Fix #106: preserve nullable bit when setting SQL_TEXT in _php_ibase_b…#110MartinKoeditz wants to merge 1 commit intomasterfrom
MartinKoeditz wants to merge 1 commit intomasterfrom
Conversation
…ind() The fallthrough path in _php_ibase_bind() unconditionally set sqltype to SQL_TEXT, discarding the nullable bit (bit 0). This caused subsequent ibase_execute() calls with NULL to be ignored for nullable columns that went through this path. Fix: use SQL_TEXT | (var->sqltype & 1) to preserve the nullable flag. Adds test: tests/issue106_001.phpt
Collaborator
|
Hi! Thanks! Most of issues tagged assigned to me has been already fixed. I have to sit down and commit them here yet :) I will check your code too. |
Collaborator
|
Test case will be useful 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ind()
The fallthrough path in _php_ibase_bind() unconditionally set sqltype to SQL_TEXT, discarding the nullable bit (bit 0). This caused subsequent ibase_execute() calls with NULL to be ignored for nullable columns that went through this path.
Fix: use SQL_TEXT | (var->sqltype & 1) to preserve the nullable flag.
Adds test: tests/issue106_001.phpt