Skip to content

Fix Firefox bookmark profile resolution for LF-formatted profiles.ini - #4643

Closed
VictoriousRaptor with Copilot wants to merge 2 commits into
devfrom
copilot/fix-firefox-bookmarks-issue
Closed

Fix Firefox bookmark profile resolution for LF-formatted profiles.ini#4643
VictoriousRaptor with Copilot wants to merge 2 commits into
devfrom
copilot/fix-firefox-bookmarks-issue

Conversation

Copilot AI commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Firefox 155 can rewrite profiles.ini with LF line endings, which broke the Browser Bookmarks loader’s CRLF-only parsing and caused Firefox bookmarks to disappear silently. This change makes profile parsing line-ending agnostic and adds regression coverage.

  • Loader fix: line-ending agnostic profiles.ini parsing

    • Replaced manual "\r\n" splitting with File.ReadAllLines(...) in FirefoxBookmarkLoader.GetProfileIniPath.
    • Preserves existing profile-selection logic while correctly handling both CRLF and LF files.
  • Regression test coverage

    • Added BrowserBookmarkPluginTest.GetProfileIniPath_ParsesDefaultProfileWithDifferentLineEndings.
    • Verifies default profile resolution for both \n and \r\n profiles.ini content.
  • Test project wiring

    • Added Browser Bookmark plugin project reference to Flow.Launcher.Test so the regression test can target the loader.
// before
var lines = ini.Split("\r\n").ToList();

// after
var lines = File.ReadAllLines(profileIni).ToList();

Co-authored-by: VictoriousRaptor <10308169+VictoriousRaptor@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Firefox bookmarks disappearance due to LF line endings Fix Firefox bookmark profile resolution for LF-formatted profiles.ini Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Browser Bookmarks: Firefox bookmarks disappear when profiles.ini uses LF line endings (Firefox 155)

2 participants