Repository navigation
fix(cli): keep the rich text editor working in newly created blocks - #1705
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c0da01f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
peter-tudosa
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the block scaffolding part of DE-683.
Blocks created with
frontify-cli createcrashed withCannot read properties of undefined (reading 'slice')as soon as a rich text editor switched to edit mode. npm putslate@0.136.0at the top level next toslate-react@0.102.0, while@frontify/fondue-rtekept its ownslate@0.102.0. The editor ran on two incompatible copies of slate. The block templates now pinslateandslate-reactto 0.102.0 andslate-historyandslate-hyperscriptto 0.100.0, the versions fondue-rte is built against.Also in the three block templates:
@frontify/app-bridgegoes from^3.12.9to^3.12.10, and@frontify/guideline-blocks-settingsfrom2.1.11to^3.0.7. It's now a caret range, so new blocks get patch releases. Dev tooling is bumped to current versions.allowScriptsnow coversesbuildandunrs-resolver, so npm stops warning about their install scripts.pnpm-workspace.yaml, the same as chore: update the apps templates #1702 added to the app templates. pnpm ignoresresolutions, and pnpm 11+ fails the install on unapproved build scripts. It uses 4-space indents because the template's ESLint config also lints YAML, anddeployruns lint.Not in this PR
braces(GHSA-vfj7-8cjw-p6xm), which has no patched release yet. It comes in through tailwind 3, fast-glob and fondue. The rest come fromkatex(through the ESLint config) andpostcss-selector-parser(through tailwind 3). All of them are build or lint tools, and none end up in the block bundle.