Repository navigation
Fix how the Roman PSF is rotated to the right sky orientation #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rmjarvis
wants to merge
13
commits into
main
Choose a base branch
from
roman_psf_skycoords
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+998
−432
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
da5b9e5
Fix how the Roman PSF is rotated to the right sky orientation
rmjarvis 4f90858
Add a test of wcs=PixelScale
rmjarvis dbd862f
Preserve the wcs in flip_ud and related functions
rmjarvis efac076
Fix the WCS to use science coordinates, incluing accounting for the r…
rmjarvis b16ba39
Fix the pupil plane coordinates again. It's not a flip it's 180 degre…
rmjarvis 39d1762
Fix the aberrations to match the entrance pupil coordinates
rmjarvis 77bc3c5
Switch to lanczos interpolant for roman psf
rmjarvis d6c1a22
Switch to using all 5 points for aberration interpolation.
rmjarvis 0ae9fdb
Add tests that compare with STPSF reference images
rmjarvis 1bec90c
Apply batched suggestions from code review
rmjarvis f1b66c4
Add test to cover flipped version
rmjarvis a135767
coverage
rmjarvis e18f676
Update roman comparison to use stpsf's cycle 9 files. And fix it to a…
rmjarvis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes - I thought when I was using the functions last time that I would take all the meta information with it, didn't realize that wasn't explicitly happening
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a reasonable assumption. Which is why I changed the default. In my review it didn't occur to me that it wouldn't keep the pixel scale. That's a sign of bad API design.