Repository navigation
Install scm()'s solver with rdborrow (0.0.5.1) - #170
Open
mattsecrest wants to merge 3 commits into
Open
mattsecrest wants to merge 3 commits into
mattsecrest wants to merge 3 commits into
Conversation
Bump the version, the NEWS heading, and the README citation. Require testthat 3.3.0, which the tests need for expect_all_true(). Exclude the untracked adversarial-review folder from the build, and update cran-comments.md.
scm() solves with ECOS, but ECOSolveR was only in Suggests, so
install.packages("rdborrow") left it out and scm() stopped with an
error. Move ECOSolveR to Imports, drop the guard and the test skips,
and bump the version to 0.0.5.1 for CRAN.
# Conflicts: # DESCRIPTION # NEWS.md # cran-comments.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scm()solves with the ECOS solver. ECOSolveR was in Suggests, soinstall.packages("rdborrow")did not install it.scm()then stopped with an error until the user installed ECOSolveR by hand.CRAN checks install suggested packages, so they did not show the problem. A clean
rocker/r-ver:4.6.1container found it. rdborrow 0.0.5.0 was installed from CRAN, and theOLE_analysis_workflowvignette failed:This PR:
@importFrom ECOSolveR ECOS_csolve);scm()and theskip_if_not_installed("ECOSolveR")calls;Estimates are unchanged.
Checks
R CMD check --as-cranon the tarball: 0 errors, 0 warnings, 2 NOTEs from the local machine (no network to verify the clock, no HTML Tidy).rocker/r-ver:4.6.1container: the 0.0.5.1 tarball installed with hard dependencies only, ECOSolveR came with it, and all five vignettes rendered.Note on the base
This branch is on
release-0.0.5.0(#169), because CRAN has 0.0.5.0. Merge #169 first, and this PR shows only the fix commit.