Skip to content

Move mode and units into post body for distance matrix#3

Merged
leenyburger merged 1 commit into
mainfrom
eng/660-flags
Apr 15, 2026
Merged

Move mode and units into post body for distance matrix#3
leenyburger merged 1 commit into
mainfrom
eng/660-flags

Conversation

@leenyburger

@leenyburger leenyburger commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Closes ENG-660.

Will need to be tested once comments on that issue are resolved.

@leenyburger

leenyburger commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

This issue illuminated an issue on the API side.
This issue is solved by this PR -> units and mode are now in the post request body. The API change does not block the CLI release.

Test Criteria

  • Send the following cli command.
echo "Washington DC" > /tmp/origins.txt
echo "New York" > /tmp/dests.txt
  • Confirm that units and mode are in the POST request body not the param, i.e. they are recieved.
  • Confirm that
geocodio distance-matrix --origins /tmp/origins.txt --destinations /tmp/dests.txt --mode straightline --units km
 Origin: Washington DC To New York
Distance           364.7 km (226.6 miles)
Duration           284 minutes

returns km as primary

  • Confirm that
geocodio distance-matrix --origins /tmp/origins.txt --destinations /tmp/dests.txt --mode straightline --units miles
 Origin: Washington DC To New York
Distance           364.7 km (226.6 miles)
Duration           284 minutes

returns miles as primary

  • Confirm that geocodio distance-matrix --origins /tmp/origins.txt --destinations /tmp/dests.txt --mode straightline and geocodio distance-matrix --origins /tmp/origins.txt --destinations /tmp/dests.txt --mode driving do not return the same thing

@leenyburger leenyburger merged commit 515294f into main Apr 15, 2026
4 checks passed
@leenyburger leenyburger added the bug Something isn't working label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant