Add Mexico support to the CLI#6
Closed
leenyburger wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
Contributor
Author
|
We changed the CLI so it doesn't do country client side validation, so this PR is no longer necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #5 (UK support). Adds Mexico as a fourth accepted
--countryvalue.Mexico is simpler than the UK addition: it's not access-gated (only
GBis) and has no country-specific field appends, so this is purely the country flag + docs + tests.Closes ENG-1113
Changes
distance --country(normalizeCountry): acceptsmexico(case-insensitive) → appends"Mexico". Bothdistanceanddistance-matrixwarning strings and flag help updated.geocode --countryusage text: now lists Mexico.--countryrows/hints.TestAppendCountry.Tests
gofmtclean ·go build ./...·go test -race ./...all pass.