fix: apply skip_serializing_none before Serialize derive on various structs - #61
Merged
George-Miao merged 2 commits intoJul 31, 2026
Merged
Conversation
…es\n\nThe attribute ordering matters: serde_with's skip_serializing_none must be\nplaced before #[derive(Serialize)] to take effect. Previously, None fields were\nserialized as null, causing qBittorrent to reject setPreferences requests with\n400 Bad Request.
The attribute ordering matters for serde_with: skip_serializing_none must be placed before #[derive(Serialize)] to take effect. Previously, None fields in GetTorrentListArg, AddTorrentArg, GetLogsArg, and several endpoint request structs were serialized as null. Add regression tests for the affected public model structs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
According to the docs,
skip_serializing_nonemust be applied before theSerializeattribute to take effect. When it is placed after,Nonefields are serialized asnullinstead of being omitted.Encountered this issue for
Preferences(400 Bad Request) but there are multiple affected structs.