Repository navigation
Conversation
Redned235
force-pushed
the
feature/custom-entity-support
branch
from
October 18, 2026 11:21
58b6820 to
144addf
Compare
Redned235
force-pushed
the
feature/custom-entity-support
branch
from
October 18, 2026 11:21
144addf to
093ee73
Compare
rtm516
requested changes
Oct 19, 2026
| maven("https://repo.nexomc.com/releases/") | ||
|
|
||
| // Jitpack | ||
| maven("https://jitpack.io/") |
Member
There was a problem hiding this comment.
Can we get an include group on this to save it taking longer to check for depends when it doesn't need to
| ) | ||
| private long hydraulic$ignoreBoot(long nextTickTime) { | ||
| if (this.server.getTickCount() == 0) { | ||
| return Util.getNanos(); |
Member
There was a problem hiding this comment.
We should be making sure it's hydraulic doing pack conversion. In case some other mod is causing a hang and we are preventing the server from killing and restarting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for custom entity conversion.
This uses the Conduit library to allow for traversing a mod's client jars without attempting to load them onto the classpath.
Custom entity support is not entirely comprehensive but captures many of the common cases. More complicated entities are unlikely to work.
Some of the changes in this PR are temporary, pending changes to Geyser. Some of these may also be better suited in PackConverter, but that may warrant further work and discussion. At the moment, they will stay in Hydraulic.
Which mods have been tested
Important note for mod authors
Given the complexity of the changes here and the numerous ways custom entity models, renderers, etc. can be defined in code, there is no guarantee this will fully work all the time. The goal of course is that mods that follow the general standard of wiring together entities, animations and renderers should work, but there is no guarantee given this.
What we want to guarantee, though
GeckoLib is given first-party support in Hydraulic, and the goal here is that any mod which uses GeckoLib for entities or animations should work without issue. This is because GeckoLib uses nearly the same model and animation files that Bedrock does, so beyond minor sanitization, it is trivial to support GeckoLib.
At the moment, these changes are still yet to be battle-tested, so there are likely to still be issues.
What we want to support
Ideally, any mod's entities which follow general standards adopted in vanilla should work. This includes models and animations exported directly through Blockbench. While there is never a guarantee it will work 100%, mod authors should expect that their models and animations created with Blockbench will work most of the time.
As with the caveat above, this may not entirely be the case presently, but as these changes become more solid over time, this should become a reasonable expectation.
What we cannot promise and hope to deliver in the future
Mods that have very complex models or animations, or use a non-standard format to offer this to players are unlikely to work. In the future, we'll introduce an API to make it easy for mod authors to natively offer Bedrock models and animations in place of the Java ones. This will reduce the conversion work Hydraulic has to do, while giving mod authors greater control over custom entities and not having to sacrifice features for Java Edition players.