Repository navigation
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing values to the
subscription_tierfield ofgoogle_discovery_engine_license_configso it accepts every tier the Discovery Engine API supports. Right now, setting a tier such asSUBSCRIPTION_TIER_ENTERPRISE_EMERGINGfails at plan time with anexpected subscription_tier to be one of [...]error, even though the API accepts it.The following values from the
SubscriptionTierAPI reference were added tommv1/products/discoveryengine/LicenseConfig.yaml, in the same order as the API docs:SUBSCRIPTION_TIER_ENTERPRISE_EMERGINGSUBSCRIPTION_TIER_EDU_EMERGINGSUBSCRIPTION_TIER_EDU_PRO_EMERGINGSUBSCRIPTION_TIER_FRONTLINE_STARTERSUBSCRIPTION_TIER_CONSUMPTION_ONLYSUBSCRIPTION_TIER_EDU_GOV_EMERGINGThe enum now matches the API's full list of 16 values.
Breaking changes: None. The change only adds allowed values to the client-side enum validation, so every existing configuration stays valid.
Versions: The field already exists in both the
googleandgoogle-betaproviders, so the change applies to both.Tests: No acceptance test was added. The resource's only generated example sets
exclude_test: truebecause creating license configs at the project level is deprecated for Gemini Enterprise, so this resource can't currently be created in the test environment. The change only adds enum values; there is no new schema, expand/flatten or custom code. Generated code was checked locally:ValidateEnumand the field documentation inresource_discovery_engine_license_config.golist all the new values.Documentation: Field documentation is generated from the YAML, and the "Possible values" list updates automatically.
Fixes hashicorp/terraform-provider-google#30632