support TIMESTAMP

[dank303]

pgadapter already supports TIMESTAMPTZ, but standard postgresql also supports TIMESTAMP as a timestamp without timezone.

This type is used in https://github.com/pressly/goose to initialize the database when used with the postgres datastore type. Having this type available would make it easier to use spanner/pgadapter as a drop-in replacement for postgresql.

[olavloite]

@dank303 Thanks for reaching out. Note that PGAdapter only does the network protocol translation, and some system query replacements, and not things like for example data type implementations. That is all in Spanner.

However, specifically for this kind of thing, it would theoretically be possible to automatically inspect and replace DDL statements that contain a timestamp column with a timestamptz column. But it would still mean that the data type in the database is timestamptz.

I'm not familiar with https://github.com/pressly/goose, but would it be possible to manually change the DDL file that uses timestamp in this case?

[dank303]

@olavloite thanks for the quick response. I've modified goose locally to use timestamptz and that's gotten me past that roadblock. I'm attempting to use spanner for storage for openfga, and this was the first one. A couple of others with ddl limitations were a bit easier to overcome. I'll reach out to the goose project to see if changing it there is a possibility.