Make DesfireCrypto header self-contained - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add the standard
<cstdint>include to the publicDesfireCrypto.hheader.Why
PR #1 exposed the implementation as a standalone CMake library. Its Linux CI then showed that the public header uses
uint8_twithout including the header that defines it. macOS received the type transitively, masking the portability issue.This makes the header self-contained and restores the CMake build on Linux.
Validation
DesfireCrypto.cppas an independent translation unit with strict warningsAES.cppindependently with strict warningsgit diff --checkpasses