fix(security): bump js-yaml past CVE-2026-59870 - #168
Merged
Conversation
npm audit started reporting a high-severity finding on main without anything in the repo changing — the advisory was published after the last green run: js-yaml 4.0.0 - 4.3.0 GHSA-5p4m-2wfm-xmqj — quadratic CPU consumption in !!omap resolution It arrives twice through json-schema-to-typescript, which generates the Desktop's protocol types, so it is a devDependency rather than something that ships. A malicious schema is not a threat model we have, but the audit gate is set to fail on high and the fix is a patch release. 4.3.0 -> 4.3.1, lockfile only; package.json is untouched. Verified with a clean npm ci: 0 vulnerabilities, check:protocol passes (it is the consumer of js-yaml), typecheck, lint, 148 tests and the production build all clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
npm auditbegan failing onmainwithout anything in the repo changing — the advisory was published after the last green run (490aad6, 08-06 15:22):It reaches us twice through
json-schema-to-typescript, which generates the Desktop's protocol types:That makes it a devDependency rather than something that ships, and a hostile schema is not a threat model this repo has. But the audit gate is set to
--audit-level=high, and the fix is a patch release, so there is no reason to carry it.Change
4.3.0 → 4.3.1, lockfile only —package.jsonis untouched and no direct dependency moved.Testing
From a clean
npm ci:npm audit --audit-level=highnpm run check:protocoljs-yaml, so it is the one that would breaknpm run typecheckeslint .vitest runnpm run buildNote on the two PRs behind this
#165 and #166 are both green on Desktop CI, Linting and Python CI, and red only on Security CI for this same finding. Neither touches npm — one is markdown, the other a Python floor. Merging this first should clear them.