feat: support translation key format resource pack desc#5965
Open
pynickle wants to merge 11 commits intoHMCL-dev:mainfrom
Open
feat: support translation key format resource pack desc#5965pynickle wants to merge 11 commits intoHMCL-dev:mainfrom
pynickle wants to merge 11 commits intoHMCL-dev:mainfrom
Conversation
Member
|
/gemini review |
Glavo
reviewed
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements localized description resolution for resource packs and refactors locale mapping to align with Minecraft's language tagging. Key updates include the introduction of ResourcepackDescriptionResolver to handle translated metadata, enhancements to LocaleUtils for identifying Minecraft-specific language files, and the propagation of locale information through the resource pack loading process. Review feedback recommends specifying UTF-8 encoding for metadata files to ensure cross-platform compatibility, optimizing loops by hoisting invariant calculations, and utilizing input streams for JSON parsing to improve memory efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
支持对 translation key 格式简介的资源包解析: