Skip to content

Fix thread list sorting with active filters #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix thread list sorting with active filters #158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8027f3
Initial plan
Copilot Jan 26, 2026
89b2433
Fix thread list sorting to preserve filtered rows
Copilot Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions organizer/src/webroot/js/tableSorting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,12 @@ document.addEventListener('DOMContentLoaded', () => {
// Toggle sort direction
sortDirection = sortDirection === 'asc' ? 'desc' : 'asc';

// Sort rows by the data-last-email-timestamp attribute
rows.sort((a, b) => {
// Separate visible and hidden rows to preserve filter state
const visibleRows = rows.filter(row => row.style.display !== 'none');
const hiddenRows = rows.filter(row => row.style.display === 'none');

// Sort only the visible rows by the data-last-email-timestamp attribute
visibleRows.sort((a, b) => {
const aTimestamp = parseInt(a.getAttribute('data-last-email-timestamp') || '0', 10);
const bTimestamp = parseInt(b.getAttribute('data-last-email-timestamp') || '0', 10);

Expand All @@ -64,12 +68,16 @@ document.addEventListener('DOMContentLoaded', () => {
// Remove all rows from the table
allRows.forEach(row => row.remove());

// Re-append header row first, then data rows
// Re-append header row first, then visible rows, then hidden rows
if (headerRow) {
tbody.appendChild(headerRow);
}

rows.forEach(row => {
visibleRows.forEach(row => {
tbody.appendChild(row);
});

hiddenRows.forEach(row => {
tbody.appendChild(row);
});

Expand Down
Loading