You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks @akortunov! I will check this a bit later, sorry for the delay – need also to dig into the lang attribute to understand whether locale can be used there, not just the two-letter codes.
Thanks @akortunov! I will check this a bit later, sorry for the delay – need also to dig into the lang attribute to understand whether locale can be used there, not just the two-letter codes.
Yeah, its allowed to use the full lang-region value in the html-attribute
Thanks @akortunov! I will check this a bit later, sorry for the delay – need also to dig into the lang attribute to understand whether locale can be used there, not just the two-letter codes.
Yeah, its allowed to use the full lang-region value in the html-attribute
Yes, it is possible (I suppose that it would be enough to replace @CultureInfo.CurrentUICulture.TwoLetterISOLanguageName to @CultureInfo.CurrentUICulture.Name).
But this change will affect the whole page instead of just moment.js and may have side effects.
For example - I suppose that ca-ES locale will fall back to en instead of ca in moment.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up work for #2574.
In upstream Hangfire, locale name is passed to Hangfire Dashboard HTML as a two-letter language name:
This tag is used as a locale name for Moment.js:
As a result, some supported locales become unused in Moment.js:
pt-brbecomes justptinsteadzh-cnandzh-twbecome justzh, which does not exist in Moment.js, so an English text is used insteadA proposed solution:
Hangfire.config, which will store the full locale name.