fix: keep selected list item always visible when scrolling#15
Open
HeyItsGilbert wants to merge 2 commits intomainfrom
Open
fix: keep selected list item always visible when scrolling#15HeyItsGilbert wants to merge 2 commits intomainfrom
HeyItsGilbert wants to merge 2 commits intomainfrom
Conversation
Implements a viewport window in Get-ListPanel that only renders the visible slice of the list. Show-PesterResult now tracks a listScrollOffset and adjusts it after every navigation key so the selected item is always on screen. Shows '...' indicators above/below when items are hidden. Also fixes a pre-existing PageUp bug where the minimum index was calculated as list.Count-1 instead of 0. Closes #11
Test Results 3 files 42 suites 1s ⏱️ For more details on these failures, see this check. Results for commit 286e41f. ♻️ This comment has been updated with latest results. |
… bug Move Get-ListPanel test setup into a single top-level BeforeAll/InModuleScope block to avoid cross-scope variable access issues with nested Context BeforeAll blocks. Also fix a pre-existing bug in Help.tests.ps1 where $parameterNames was used instead of $commandParameterNames, causing 3 permanent test failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a viewport window in Get-ListPanel that only renders the
visible slice of the list. Show-PesterResult now tracks a
listScrollOffset and adjusts it after every navigation key so the
selected item is always on screen. Shows '...' indicators above/below
when items are hidden. Also fixes a pre-existing PageUp bug where the
minimum index was calculated as list.Count-1 instead of 0.
Closes #11