DEV-678 Info Component Popover UI - #507
Open
hannahchoi05 wants to merge 6 commits into
Open
hannahchoi05 wants to merge 6 commits into
hannahchoi05 wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Proposed Changes
InfoComponentPopOverrenders course details anchored to the search result instead of opening a full-screen modal.SortableItemwraps search-result items in the popover./course/details/and passesterm_codeto/course/comments/so reviews reflect the selected semester. Term selection defaults to the newest term that actually has feedback, rather than walking the term list by index.courseDetails, so a failed detail fetch no longer sticks — reopening the popover retries instead of showing a cached error. Successful responses stay cached.Follow-Up Notes / Known Bugs - (edit: both resolved in this PR)