Skip to content

check-prs: use curl to reduce GitHub REST API usage - #506

Merged
cho-m merged 2 commits into
mainfrom
check-prs-curl
Nov 1, 2026
Merged

cho-m merged 2 commits into
mainfrom
check-prs-curl

Conversation

@cho-m

@cho-m cho-m commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Trying to reduce some GitHub REST API usage as we are exceeding 15k/hour. This one seems safe to use curl instead but may need someone to check if there are any other features of gh api that may be missing with change

@cho-m
cho-m marked this pull request as ready for review October 31, 2026 21:06

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, thanks!

@cho-m
cho-m requested a review from a team as a code owner October 31, 2026 21:06
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ab8583ad-53ae-4cf5-ae13-bc0d3c2bb77b
Commits

Reviewing files that changed from the base of the PR and between 885069d and 40143ed.

Files selected for processing: 2
  • .github/actions/sync/shared-config.rb
  • .github/workflows/check-prs.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Summary

Summary by CodeRabbit

  • Chores
    • Updated the behind-the-scenes pull request validation process to retrieve its templates and checks more reliably. The checks continue to use the latest versions from their respective repositories, and downloads now handle redirects, retry temporary failures and report HTTP errors. These maintenance changes do not alter the app’s features or behaviour for end-users.

The pull request adds a RuboCop directive around a Ruby helper. It also changes two workflow downloads to use raw GitHub URLs with curl.

Changes: RuboCop directive

Layer / File(s) Summary
Suppress duplicate-method lint
.github/actions/sync/shared-config.rb
The Lint/DuplicateMethods cop is disabled around the top-level git(*args) helper. The helper implementation is unchanged.

Workflow downloads

Layer / File(s) Summary
Download template and checker
.github/workflows/check-prs.yml
The workflow uses curl to download the template from the current repository’s main branch and the checker from Homebrew/.github’s main branch. Both requests fail on HTTP errors, follow redirects, retry up to three times, and suppress normal output while showing errors.
Merge Risk: Minimal · up to 40143

No actionable merge-blocking risk is established; the changes preserve the workflow’s successful behavior while reducing API usage.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: replacing GitHub REST API usage with curl in check-prs.
Description check Passed The description relates directly to the changeset and explains the goal of reducing GitHub REST API usage. It also identifies the need to verify feature parity.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cho-m
cho-m merged commit 631ab00 into main Nov 1, 2026
27 checks passed
@cho-m
cho-m deleted the check-prs-curl branch November 1, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants