Add 'get' canvas functions to ranges - #79
Conversation
MImranAsghar
commented
Nov 23, 2020
- Add getCanvases, getCanvasById, getCanvasByIndex functions for the range type
d0e842d to
53830e3
Compare
|
I'm not sure why, but 3 tests appear to be failing now: |
|
Ah interesting, looking into it 👍 |
53830e3 to
87399d8
Compare
|
Hi @stephenwf , fixed the tests |
- Create getCanvases, getCanvasById, getCanvasByIndex functions for the range type
sequence to range as well - Add test for getCanvasById range
... index to each canvas in range
87399d8 to
2bd289b
Compare
... ranges when getting canvases
2bd289b to
53a2e81
Compare
|
Hi @stephenwf , I was wondering if you got a chance to take a look at the changes. do you think this can be merged? 🤔 |
|
Sorry yes I think so 👍 @edsilv ? |
|
Hello Manifesto team, we are auditing some older issues and wondering if this is still a candidate to be merged. |
|
Thanks for checking in, @marlo-longley. I haven't previously reviewed this one (at the time this was going on, I wasn't as active in this project), but I'm certainly open to giving it a closer look. It seems that there are some conflicts that need to be resolved, though, so the first question is how we get this in shape to be mergeable. Is @MImranAsghar still actively engaged with this? If not, should we close this PR and open a fresh one that somebody is able to maintain? |
|
@demiankatz thanks! Yes, I rebased this branch and put up a new PR here #181 |
|
Great, I'll close this PR so we can focus on the new one. Thanks, @marlo-longley! |