fix(chat): elaborate the bidirectionality of the messages array - #438
Merged
Conversation
ChronosSF
commented
Jul 16, 2026
ChronosSF
commented
Member
- Documented messages as a bidirectional collection.
- [Angular] Clarified that Chat mutates the bound collection in place, rather than supporting Angular banana-in-a-box two-way binding syntax.
- Warned against appending the message again in messageCreated.
- Added an array-spread example to preserve the original collection.
- Explained that the shallow copy still shares existing message objects.
gedinakova
approved these changes
Jul 17, 2026
gedinakova
added
the
✅ status: verified
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.