wpf test fixes for grahams input branch - #1041
Merged
Merged
Conversation
Member
Author
|
@copilot update the lock file for tools please |
Co-authored-by: gmurray81 <4264873+gmurray81@users.noreply.github.com>
Contributor
Addressed in |
…csPK GroupG1AndA, GroupG1GreaterThan and GroupG1LessThan imported IgcGridCustomFilterRequestedEventArgs from igniteui-webcomponents-grids - the non-xplat grid package, which does not export it at any version. The type belongs to the XPlatform DataGrid and is emitted into igniteui-webcomponents-data-grids, which is where the three sibling samples using the same type already import it from. All three of these have Blazor.cs, GTK.cs and WPF.cs alongside Web.ts, and WPF.cs uses Infragistics.Controls.Grids.GridCustomFilterRequestedEventArgs, so they are xplat samples; the 80 remaining samples on the grids package are all Web* prefixed with no desktop variant, and are untouched. WebGridEditedRowClassesHandler used this.updatedRecsPK without declaring it. The declaration goes inside the eventHandler markers because only the marked regions are emitted - outside them it is dropped - which is where its paired sample WebGridPasteFromExcel declares its own copy. Blazor shares one module-level var between the pair; in TypeScript each class carries its own. Nothing caught either of these because the vite hosts did not type check. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.