Conversation
These three existed only as GTK.cs and Web.ts, so every scenario that binds one failed on Android with "library does not have item" -- four of the chart accessibility scenarios, and they would block WinUI, WPF and iOS the same way whenever those run them. The AddAction one differs from its siblings on purpose. The other platforms guard with "if actions == null" and then add through the property; on Android the wrapper's getter lazily builds a collection that reads from the implementation but carries no sync target, so the guard never fires and items added through that collection never reach the implementation. Assigning the collection first is what wires the write-through, so this assigns and then adds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: gmurray81 <4264873+gmurray81@users.noreply.github.com>
The rename of AccessibilityNode.Description to DescriptionText landed in dev-tools, which cannot reach this repo: six handlers here still assigned the old property. These items compile into each platform's emitted sample library, so this broke the library build on GTK, Web and Android rather than just failing a test. The three items also shipped only GTK.cs, Web.ts and Android.kt, so WindowsForms, WPF, WinUI and Uno got no samples at all and every scenario binding one failed with "library does not have item". Desktop.cs is the shared desktop variant -- it covers WPF, WindowsForms, GTK, WinUI and Uno -- so one file per item closes all four. Verified through the emitter and the suites: GTK and Android build and run green with these; WindowsForms now emits all three items. Still missing: Swift, .NET iOS and .NET Android have no variant for these items, so those lanes will fail the scenarios that bind them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…/github.com/IgniteUI/igniteui-xplat-examples into gmurray/chart-accessibility-android-samples
This reverts 21922c9. Filtering TestsAccessibility* out of the emission was a hold-the-line measure while those items were not building; they are in main now and the handlers have been corrected for the DescriptionText rename, so the emitter can carry them again. tooling: 17 tests, 17 pass with the filter gone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These three existed only as GTK.cs and Web.ts, so every scenario that binds one failed on Android with "library does not have item" -- four of the chart accessibility scenarios, and they would block WinUI, WPF and iOS the same way whenever those run them.
The AddAction one differs from its siblings on purpose. The other platforms guard with "if actions == null" and then add through the property; on Android the wrapper's getter lazily builds a collection that reads from the implementation but carries no sync target, so the guard never fires and items added through that collection never reach the implementation. Assigning the collection first is what wires the write-through, so this assigns and then adds.