Skip to content

Match the return type of core.bitop.bsr and core.bitop.bsf #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LunaTheFoxgirl merged 1 commit into from
Jun 25, 2026
Merged

Match the return type of core.bitop.bsr and core.bitop.bsf #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions source/numem/core/math.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,15 +94,15 @@ auto ref T nu_max(T)(auto ref T a, auto ref T b) @nogc nothrow @trusted pure if
The index of the first bit set, value is undefined
if value is zero.
*/
T nu_bsr(T)(T value) @nogc nothrow @trusted pure
int nu_bsr(T)(T value) @nogc nothrow @trusted pure
if (__traits(isIntegral, T)) {
version(LDC) {
import ldc.intrinsics : llvm_ctlz;
return cast(int)(value.sizeof * 8 - 1 - llvm_ctlz(value, true));
} else {

// Slow software implementation.
uint offset = 0;
int offset = 0;
T mask = cast(T)~(T.max >>> 1);
foreach(i; 0..T.sizeof*8) {
if (value & mask)
Expand All @@ -128,15 +128,15 @@ if (__traits(isIntegral, T)) {
The index of the first bit set, value is undefined
if value is zero.
*/
T nu_bsf(T)(T value) @nogc nothrow @trusted pure
int nu_bsf(T)(T value) @nogc nothrow @trusted pure
if (__traits(isIntegral, T)) {
version(LDC) {
import ldc.intrinsics : llvm_cttz;
return cast(int)(llvm_cttz(value, true));
} else {

// Slow software implementation.
uint offset = 0;
int offset = 0;
T mask = 1;
foreach(i; 0..T.sizeof*8) {
if (value & mask)
Expand Down
Loading