Support buffer protocol objects as advanced index keys#2889
Merged
Conversation
vlad-perevezentsev
requested review from
antonwolfy and
ndgrigorian
as code owners
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev0=py313h509198e_60 ran successfully. |
ndgrigorian
reviewed
May 4, 2026
antonwolfy
reviewed
May 5, 2026
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
May 6, 2026
Collaborator
|
coverage: 78.251% (+0.02%) from 78.233% — support_buffer_protocol_indexing into master |
antonwolfy
approved these changes
May 18, 2026
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM with small nit below
antonwolfy
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes by adding support for buffer protocol objects (
array.array,memoryviewetc.) as advanced index keysThese changes were proposed in #2872 as an extension to the advanced indexing support.