Version 4.0.0 - Windows - #147
Merged
Merged
Conversation
Added muli profile
improve code quality and performance in various services and view models
…ce Dependabot configuration
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Buffer Overflow and DOS
Comment on lines
+96
to
+100
| private static readonly string ProfilesDirectory = Path.Combine( | ||
| Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), | ||
| "ProxyBridge", | ||
| "profiles" | ||
| ); |
|
|
|
||
| [DllImport(DllName, CallingConvention = CallingConvention.Cdecl)] | ||
| [DllImport(DllName, CallingConvention = CallingConvention.Cdecl, EntryPoint = "ProxyBridge_AddProxyConfig")] | ||
| private static extern uint ProxyBridge_AddProxyConfig_Native( |
| [DllImport(DllName, CallingConvention = CallingConvention.Cdecl, EntryPoint = "ProxyBridge_EditProxyConfig")] | ||
| [return: MarshalAs(UnmanagedType.Bool)] | ||
| public static extern bool ProxyBridge_SetProxyConfig( | ||
| private static extern bool ProxyBridge_EditProxyConfig_Native( |
|
|
||
| [DllImport(DllName, CallingConvention = CallingConvention.Cdecl)] | ||
| [return: MarshalAs(UnmanagedType.Bool)] | ||
| public static extern bool ProxyBridge_DeleteProxyConfig(uint configId); |
| public static extern bool ProxyBridge_DeleteProxyConfig(uint configId); | ||
|
|
||
| [DllImport(DllName, CallingConvention = CallingConvention.Cdecl, CharSet = CharSet.Ansi, EntryPoint = "ProxyBridge_TestProxyConfig")] | ||
| private static extern int ProxyBridge_TestProxyConfig_Native( |
| } | ||
|
|
||
| private static string GetProfilePath(string name) | ||
| => Path.Combine(ProfilesDirectory, Path.GetFileName(name) + ProfileExtension); |
| throw new ArgumentException("Proxy IP must not be null or empty.", nameof(proxyIp)); | ||
| username ??= string.Empty; | ||
| password ??= string.Empty; | ||
| return ProxyBridge_AddProxyConfig_Native(type, proxyIp, proxyPort, username, password); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Required Pre-Submission Checklist
devbranch (NOTmaster)masterbranch is ONLY updated when a new release is createdmasterwill be REJECTED⛔ Critical Information
DO NOT submit a pull request directly to the
masterbranch. The master branch is only updated when a new release is created. No direct commits or merges are accepted to master - neither from the InterceptSuite team nor from contributors.All changes MUST be submitted to the
devbranch, which contains the latest code and commits.You MUST create a GitHub issue first before submitting a pull request. This allows the InterceptSuite team to:
Pull requests without an associated issue will be rejected.
Pull Request Details
Type of Change
Related GitHub Issue
Issue Link:
Platform(s) Affected
macOS Application Changes
Does this pull request include changes to the macOS application?
If YES, you MUST answer the following:
macOS Code Signing & Verification
Description of Changes
What does this pull request do?
How has this been tested?
Compilation & Dependencies
New dependencies (if any):
Screenshots/Logs (if applicable)
Additional Context
Final Checklist
devbranch