test(chain-gen): add block.size regression test for #1451#2145
Merged
Conversation
Guards Era/Shelley/Generic/Block.hs blockSize against regressing from pHeaderBlockSize (full block size) back to pHeaderSize (header only), the bug behind #1451. Forges an empty block and a block with chained payment txs, then asserts the tx-bearing block records a larger block.size.
kderme
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1451
Guards Era/Shelley/Generic/Block.hs blockSize against regressing from pHeaderBlockSize (full block size) back to pHeaderSize (header only), the bug behind #1451. Forges an empty block and a block with chained payment txs, then asserts the tx-bearing block records a larger block.size.
Description
Add your description here, if it fixes a particular issue please provide a link to the issue.
Checklist
Any changes are noted in the changelogfourmoluon version 0.17.0.0 (which can be run withscripts/fourmolize.sh)Migrations
The pr causes a breaking change of type a,b or cIf there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possibleResyncing and running the migrations provided will result in the same database semanticallyIf there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.