Repository navigation
Make enum, role and permission labels translatable - #803
Merged
nielsdrost7 merged 2 commits intoOct 26, 2026
Merged
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 25, 2026
Closed
TheFreeman
force-pushed
the
fix/translatable-enum-labels
branch
from
October 25, 2026 16:28
ef80346 to
50cb289
Compare
TheFreeman
marked this pull request as ready for review
October 25, 2026 16:28
Author
|
@nielsdrost7 PR #803 is now ready for review. It has been rebased onto develop after #802 was merged. This PR only covers translatable enum, role and permission labels. |
Collaborator
|
@TheFreeman thanks man! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Checklist
develop.)developcommit252564ded3810ba9ca62f0aec11c85b801f291c4after Respect profile language in panels, Livewire and account mail #802 was merged on 2026-10-25.)Description
Route hardcoded enum display labels and permission names through English source catalogues. Translate known role names on the permissions page while retaining the fallback for custom roles.
Enum backing values, permission and role identifiers, colors and authorization behavior remain unchanged. No German catalogue is included; translations can follow through Crowdin after the source keys are accepted.
Related Issue(s)
No dedicated accompanying issue has been identified or linked. The issue-ID checklist item remains open; this PR does not claim to close an issue.
Previous review package: #802, now merged. This branch is rebased on the resulting develop; its diff contains only enum, role and permission label changes and their tests.
Relevant
.github/CHECKLIST.mdrows: core / layout and settings, expenses, payments, projects — Translations.Motivation and Context
Changing the application locale currently leaves status/type choices and the role-permissions page partly in English because their display labels are hardcoded. Source translation keys allow those existing labels to follow the active locale while preserving stored values and access checks.
This is the next focused package for review after the profile-language fix in #802 was merged. Larger form-label and document-format changes are held in the fork; see the contribution sequence.
Issue Type
Validation
php artisan test --filter=EnumLocalizationTest2 tests / 8 assertions passed on this independent branch at
50cb28971ff076e97de2cfa89c3cca4293f172bc(PHP 8.4, locked dependencies), without German catalogue files. Coverage includes changing the locale at runtime and keeping storage/permission values stable. Laravel Pint formatting was checked. Test methods use grammaticalit_names and explicit Arrange, Act, Assert sections; assertions are separated from the exercised behavior. The local results above were rechecked after this test-only follow-up. These results describe local validation, not an assertion that upstream CI has passed.After rebasing on the merged profile-language package, the combined locale, real Livewire-update, menu and enum tests passed: 13 tests / 52 assertions. Command:
php artisan test --filter='UserLocaleTest|UserLocaleLivewireTest|UserMenuLocalizationTest|EnumLocalizationTest'PHP 8.4, isolated MariaDB and locked dependencies; Pint passed for all 22 changed files.
Screenshots
No screenshot attached: the change makes existing labels translatable and preserves the layout. Tests inject translations to verify the behavior without requiring additional language catalogues.