Repository navigation
🐛 fix(ci): bump mkdocstrings, pytest-codspeed and zensical to fix main CI - #82
Conversation
…n CI JAXtronomy#81's dependency bump broke two required checks on every PR against main: - Docs: zensical 0.0.73 crashed building any page with an mkdocstrings block (`TypeError: Highlight.__init__() missing 1 required positional argument: 'md'`), since mkdocstrings 1.0.6 wasn't bumped alongside it. - Run benchmarks: pytest 9.2.0's internal `FixtureManager` dropped `_arg2fixturedefs`, which pytest-codspeed 5.0.3 still read directly, crashing collection for every benchmark (`AttributeError`). Both are fixed by the next patch release of the package that was actually incompatible, not by reverting the bump: mkdocstrings 1.0.6 -> 1.0.8 and pytest-codspeed 5.0.3 -> 5.0.4. zensical 0.0.73 -> 0.0.74 is along for the ride (its own latest patch). Verified locally: `zensical build --strict` finds no issues, and `pytest --codspeed` on `benchmarks/test_beta.py` collects and runs all 13 benchmarks. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 20.98%3 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
#81's dependency bump broke two required checks on every PR against
main:zensical0.0.73 crashed building any page with anmkdocstringsblock (TypeError: Highlight.__init__() missing 1 required positional argument: 'md'), sincemkdocstrings1.0.6 wasn't bumped alongside it.pytest9.2.0's internalFixtureManagerdropped_arg2fixturedefs, whichpytest-codspeed5.0.3 still read directly, crashing collection for every benchmark (AttributeError).Both are fixed by the next patch release of the package that was actually incompatible, not by reverting the bump:
mkdocstrings1.0.6 → 1.0.8 andpytest-codspeed5.0.3 → 5.0.4.zensical0.0.73 → 0.0.74 is along for the ride (its own latest patch).pyproject.tomlneeds no change — the existing>=constraints already allow these versions; onlyuv.lockmoves.Verified locally
uv run --frozen zensical build --clean --strict→No issues founduv run --frozen --group bench pytest benchmarks/test_beta.py -q --codspeed→ 13 passeduv run nox -s lint(precommit + pylint) → cleanuv run pytest tests/smoke -q→ 59 passed🤖 Generated with Claude Code