Skip to content

🐛 fix(ci): bump mkdocstrings, pytest-codspeed and zensical to fix main CI - #82

Merged
nstarman merged 1 commit into
JAXtronomy:mainfrom
nstarman:fix-docs-benchmark-ci
Nov 3, 2026
Merged

nstarman merged 1 commit into
JAXtronomy:mainfrom
nstarman:fix-docs-benchmark-ci

Conversation

@nstarman

@nstarman nstarman commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

#81's dependency bump broke two required checks on every PR against main:

  • Docs: zensical 0.0.73 crashed building any page with an mkdocstrings block (TypeError: Highlight.__init__() missing 1 required positional argument: 'md'), since mkdocstrings 1.0.6 wasn't bumped alongside it.
  • Run benchmarks: pytest 9.2.0's internal FixtureManager dropped _arg2fixturedefs, which pytest-codspeed 5.0.3 still read directly, crashing collection for every benchmark (AttributeError).

Both are fixed by the next patch release of the package that was actually incompatible, not by reverting the bump: mkdocstrings 1.0.6 → 1.0.8 and pytest-codspeed 5.0.3 → 5.0.4. zensical 0.0.73 → 0.0.74 is along for the ride (its own latest patch). pyproject.toml needs no change — the existing >= constraints already allow these versions; only uv.lock moves.

Verified locally

  • uv run --frozen zensical build --clean --strict → No issues found
  • uv run --frozen --group bench pytest benchmarks/test_beta.py -q --codspeed → 13 passed
  • uv run nox -s lint (precommit + pylint) → clean
  • uv run pytest tests/smoke -q → 59 passed

🤖 Generated with Claude Code

…n CI

JAXtronomy#81's dependency bump broke two required checks on every PR against main:

- Docs: zensical 0.0.73 crashed building any page with an mkdocstrings
  block (`TypeError: Highlight.__init__() missing 1 required positional
  argument: 'md'`), since mkdocstrings 1.0.6 wasn't bumped alongside it.
- Run benchmarks: pytest 9.2.0's internal `FixtureManager` dropped
  `_arg2fixturedefs`, which pytest-codspeed 5.0.3 still read directly,
  crashing collection for every benchmark (`AttributeError`).

Both are fixed by the next patch release of the package that was actually
incompatible, not by reverting the bump: mkdocstrings 1.0.6 -> 1.0.8 and
pytest-codspeed 5.0.3 -> 5.0.4. zensical 0.0.73 -> 0.0.74 is along for the
ride (its own latest patch). Verified locally: `zensical build --strict`
finds no issues, and `pytest --codspeed` on `benchmarks/test_beta.py`
collects and runs all 13 benchmarks.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 3, 2026 10:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@nstarman nstarman added this to the v0.3.0 milestone Nov 3, 2026
@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nstarman
nstarman merged commit a65ee5a into JAXtronomy:main Nov 3, 2026
14 checks passed
@nstarman
nstarman deleted the fix-docs-benchmark-ci branch November 3, 2026 10:24
@codspeed

codspeed Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 20.98%

3 warnings, 1 note

⚠️ 65 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 5 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚠️ 5 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

ℹ️ 80 benchmarks have no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

⚡ 1 improved benchmark
❌ 4 regressed benchmarks
✅ 71 untouched benchmarks
🆕 4 new benchmarks
⏩ 16 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ test_zeta_vector[negative-n1] 630.5 µs 1,656.6 µs -61.94%
❌ test_polylog_scalar[intermediate-z1] 754.5 µs 1,101.6 µs -31.51%
❌ test_polylog_scalar[large-z2] 786.8 µs 896.9 µs -12.28%
❌ test_polylog_scalar[small-z0] 1.1 ms 1.2 ms -10.63%
⚡ test_zeta_vector[positive-n0] 940.6 µs 624.1 µs +50.72%
🆕 test_incomplete_beta_a_eq_1[closed_form] N/A 524.3 µs N/A
🆕 test_incomplete_beta_a_eq_1[series] N/A 1.6 ms N/A
🆕 test_grad_incomplete_beta_a_eq_1_b[closed_form] N/A 557.6 µs N/A
🆕 test_grad_incomplete_beta_a_eq_1_b[series] N/A 25.7 ms N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing nstarman:fix-docs-benchmark-ci (e78f14d) with main (a259fff)2

Open in CodSpeed

Footnotes

  1. 16 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (2e35f84) during the generation of this report, so a259fff was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

nstarman added a commit to nstarman/spexial that referenced this pull request Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants