Skip to content

refactor: drop the dead crypto_key column/field - #66

Merged
JarbasAl merged 1 commit into
devfrom
fix/drop-dead-crypto-key
Sep 4, 2026
Merged

refactor: drop the dead crypto_key column/field#66
JarbasAl merged 1 commit into
devfrom
fix/drop-dead-crypto-key

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Sep 4, 2026

Copy link
Copy Markdown
Member

🤖 Auto-generated by Claude Sonnet 5 (claude-sonnet-5) via Claude Code — NOT human-reviewed. Verify before acting.

Removes crypto_key from SQLiteDB (column list, CREATE TABLE, insert/select column lists, value tuple, and Client(...) construction). Core no longer reads or writes crypto_key since the v3-Noise-only flag day; hivemind_plugin_manager.database.Client.crypto_key still exists (dropped in a later phase) but this plugin stops touching it.

Migration note: existing on-disk databases keep the now-unused crypto_key column — harmless dead weight in SQLite. No destructive migration is added to drop it from existing databases. New databases created after this change never get the column at all, since it is removed from the CREATE TABLE statement.

Also fixes two e2e tests whose _HivescopeDBAdapter.add_client forwarded crypto_key into hivemind_core.database.ClientDatabase.add_client, which had already dropped that kwarg upstream (a pre-existing failure once run against current hivemind-core, exposed while re-running the suite here). The adapters still accept crypto_key from hivescope's MasterNode.register_satellite call signature, but now drop it instead of forwarding it.

Updated tests/test_sqlitedb.py::test_full_client_fields_preserved to assert r.crypto_key is None (previously asserted the round-tripped value) since the field is no longer persisted or read back.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: e6a5cab0-76a9-4749-84de-ca277204591d


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Back again! I've just finished another round of automated checks. 🔄

I've aggregated the results of the automated checks for this PR below.

📋 Repo Health

I've checked the repo's reflexes (aka build speed). ⚡

✅ All required files present.

Latest Version: 0.4.3a6

hivemind_sqlite_database/version.py — Version file
README.md — README
LICENSE.md — License file (consider renaming to LICENSE)
pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
CHANGELOG.md — Changelog
hivemind_sqlite_database/version.py has valid version block markers

🏷️ Release Preview

Ensuring our release announcement is ready for prime time. 📺

Current: 0.4.3a6Next: 0.4.3a7

Signal Value
Label (none)
PR title refactor: drop the dead crypto_key column/field
Bump alpha

✅ PR title follows conventional commit format.


🚀 Release Channel Compatibility

Predicted next version: 0.4.3a7

Channel Status Note Current Constraint
Stable Not in channel -
Testing Not in channel -
Alpha Compatible hivemind-sqlite-database>=0.4.3a6

⚖️ License Check

Are we all good on the legal front? Let's find out! 📑

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔒 Security (pip-audit)

Ensuring our data is safe and secure. 🔐

✅ No known vulnerabilities found (70 packages scanned).

📊 Coverage

How deep does the testing rabbit hole go? 🐇

85.6% total coverage

Per-file coverage (2 files)
File Coverage Missing lines
hivemind_sqlite_database/version.py 0.0% 5
hivemind_sqlite_database/__init__.py 87.8% 24

Full report: download the coverage-report artifact.

🔨 Build Tests

The compiler has spoken! Here is the verdict. 📜

✅ All versions pass

Python Build Install Tests
3.10
3.11
3.12
3.13
3.14

The bits must flow. 🌊

@JarbasAl
JarbasAl marked this pull request as ready for review September 4, 2026 21:31
@JarbasAl
JarbasAl merged commit e857671 into dev Sep 4, 2026
15 checks passed
@JarbasAl
JarbasAl deleted the fix/drop-dead-crypto-key branch September 4, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant