refactor: drop the dead crypto_key column/field - #66
Conversation
…no longer uses it)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Back again! I've just finished another round of automated checks. 🔄I've aggregated the results of the automated checks for this PR below. 📋 Repo HealthI've checked the repo's reflexes (aka build speed). ⚡ ✅ All required files present. Latest Version: ✅ 🏷️ Release PreviewEnsuring our release announcement is ready for prime time. 📺 Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
⚖️ License CheckAre we all good on the legal front? Let's find out! 📑 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔒 Security (pip-audit)Ensuring our data is safe and secure. 🔐 ✅ No known vulnerabilities found (70 packages scanned). 📊 CoverageHow deep does the testing rabbit hole go? 🐇 ✅ 85.6% total coverage Per-file coverage (2 files)
Full report: download the 🔨 Build TestsThe compiler has spoken! Here is the verdict. 📜 ✅ All versions pass
The bits must flow. 🌊 |
Removes
crypto_keyfromSQLiteDB(column list,CREATE TABLE, insert/select column lists, value tuple, andClient(...)construction). Core no longer reads or writescrypto_keysince the v3-Noise-only flag day;hivemind_plugin_manager.database.Client.crypto_keystill exists (dropped in a later phase) but this plugin stops touching it.Migration note: existing on-disk databases keep the now-unused
crypto_keycolumn — harmless dead weight in SQLite. No destructive migration is added to drop it from existing databases. New databases created after this change never get the column at all, since it is removed from theCREATE TABLEstatement.Also fixes two e2e tests whose
_HivescopeDBAdapter.add_clientforwardedcrypto_keyintohivemind_core.database.ClientDatabase.add_client, which had already dropped that kwarg upstream (a pre-existing failure once run against current hivemind-core, exposed while re-running the suite here). The adapters still acceptcrypto_keyfromhivescope'sMasterNode.register_satellitecall signature, but now drop it instead of forwarding it.Updated
tests/test_sqlitedb.py::test_full_client_fields_preservedto assertr.crypto_key is None(previously asserted the round-tripped value) since the field is no longer persisted or read back.