Repository navigation
Add Jelly-RDF 1.2 protos & tests, update Jelly-SPARQL column layouts - #117
Merged
Merged
Conversation
sparql.proto as in the work-in-progress spec, with RdfColumn copied in as SparqlColumn (same wire format) and rdf2.proto still imported, so that Jelly-RDF keeps compiling until the new rdf.proto lands.
This comment was marked as outdated.
This comment was marked as outdated.
Ostrzyciel
added a commit
to Jelly-RDF/jelly-jvm
that referenced
this pull request
Oct 9, 2026
Does not implement Jelly-RDF 1.2 yet, just bumps the proto to the same one as in Jelly-RDF/jelly-protobuf#117 There are many small changes in Jelly-SPARQL due to the new proto having only one column kind. In general the behavior is mostly the same, just the binary layout is slightly different. We will be able to later take out large chunks of the column-handling code to Jelly-RDF.
apparently RDF4J does this and it is allowed
…olumn-exp # Conflicts: # proto/rdf.proto # proto/rdf2.proto # proto/sparql.proto
|
The latest Buf updates on your PR. Results from workflow Protobuf checks / buf (pull_request).
|
Member
Author
|
(the breaking changes are fine, they are all in the draft SPARQL format) |
Ostrzyciel
changed the title
Ostrzyciel
requested review from
nk2IsHere
and removed request for
adanilenka
October 17, 2026 13:11
This was referenced Oct 17, 2026
nk2IsHere
reviewed
Oct 19, 2026
nk2IsHere
reviewed
Oct 19, 2026
nk2IsHere
reviewed
Oct 19, 2026
nk2IsHere
reviewed
Oct 19, 2026
nk2IsHere
reviewed
Oct 19, 2026
nk2IsHere
reviewed
Oct 19, 2026
nk2IsHere
reviewed
Oct 19, 2026
nk2IsHere
reviewed
Oct 19, 2026
nk2IsHere
reviewed
Oct 19, 2026
nk2IsHere
reviewed
Oct 19, 2026
nk2IsHere
reviewed
Oct 19, 2026
nk2IsHere
reviewed
Oct 19, 2026
Ostrzyciel
added a commit
to Jelly-RDF/jelly-rdf.github.io
that referenced
this pull request
Oct 19, 2026
Review together with: Jelly-RDF/jelly-protobuf#117 - Added the RDF 1.2 spec - To keep the spec simple, it only describes how to work with Jelly-RDF 1.2, not 1.1 or 1.0. In case the stream uses an older version of Jelly, the consumer is instructed to follow the Jelly-RDF 1.1 spec instead. - Refactored the SPARQL spec, moving anything shared (e.g., how columns work) to the RDF spec
nk2IsHere
approved these changes
Oct 19, 2026
This was referenced Oct 19, 2026
Ostrzyciel
added a commit
to Jelly-RDF/jelly-rdf.github.io
that referenced
this pull request
Oct 19, 2026
Following the discussion in: Jelly-RDF/jelly-protobuf#117 Side note: 1.1-only consumer will simply ignore these fields, so it's best to say we ignore this. Adding a SHOULD here would require adding extra test cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review together with: Jelly-RDF/jelly-rdf.github.io#115
This implements #102, #41, and #59
The breaking changes reported by the buf linter are fine, they are all in the draft SPARQL format.