Skip to content

Fix chessboard list parsing with XML.jl 0.4 - #101

Merged
ViralBShah merged 1 commit into
masterfrom
vs/fix-xml-list-parsing
Sep 13, 2026
Merged

ViralBShah merged 1 commit into
masterfrom
vs/fix-xml-list-parsing

Conversation

@ViralBShah

Copy link
Copy Markdown
Member

CI on master (and on every open PR, e.g. #100) fails in test_corner_detection.jl:

BoundsError: attempt to access Tuple{} at index [0]
  @ XML/src/lazynode.jl getindex
  @ get_list test/test_corner_detection.jl:27

XML.jl 0.4 (released 2026-07-03) preserves whitespace text nodes, so doc[end][end] now selects the trailing newline Text node after </opencv_storage> instead of <boards>. This selects the child elements by node type instead of by position, and skips empty lines. Verified locally against chessboard_list.dat with XML.jl 0.3.9 and 0.4.6.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PmWrWgg2EMqDnvWEmyQ3AZ

XML.jl 0.4 preserves whitespace text nodes, so `doc[end][end]` now
picks a trailing newline Text node instead of `<boards>`, and
`simple_value` on it throws a BoundsError. Select child elements by
node type instead of position. Works with XML.jl 0.3 and 0.4.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PmWrWgg2EMqDnvWEmyQ3AZ
@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.45%. Comparing base (d03fe72) to head (ee80e1a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files          11       11           
  Lines         234      234           
=======================================
  Hits          214      214           
  Misses         20       20           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah
ViralBShah merged commit 3614d33 into master Sep 13, 2026
10 checks passed
@ViralBShah
ViralBShah deleted the vs/fix-xml-list-parsing branch September 13, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant