Repository navigation
Fix chessboard list parsing with XML.jl 0.4 - #101
Merged
Merged
Conversation
XML.jl 0.4 preserves whitespace text nodes, so `doc[end][end]` now picks a trailing newline Text node instead of `<boards>`, and `simple_value` on it throws a BoundsError. Select child elements by node type instead of position. Works with XML.jl 0.3 and 0.4. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PmWrWgg2EMqDnvWEmyQ3AZ
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 11 11
Lines 234 234
=======================================
Hits 214 214
Misses 20 20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on master (and on every open PR, e.g. #100) fails in
test_corner_detection.jl:XML.jl 0.4 (released 2026-07-03) preserves whitespace text nodes, so
doc[end][end]now selects the trailing newlineTextnode after</opencv_storage>instead of<boards>. This selects the child elements by node type instead of by position, and skips empty lines. Verified locally againstchessboard_list.datwith XML.jl 0.3.9 and 0.4.6.🤖 Generated with Claude Code
https://claude.ai/code/session_01PmWrWgg2EMqDnvWEmyQ3AZ