CompatHelper: bump compat for JSON to 1, (keep existing compat)#15
Merged
s-celles merged 1 commit intoMay 17, 2026
Merged
Conversation
s-celles
force-pushed
the
compathelper/new_version/2026-05-17-04-01-07-055-01455744853
branch
from
7c6fcdf to
efd1c81
Compare
s-celles
added a commit
that referenced
this pull request
May 17, 2026
The Format Check workflow runs only on pull_request and was added recently, so the v1->v2 style drift on main had never been validated. Three CompatHelper PRs (#13, #14, #15) tripped the check, failing on pre-existing formatting rather than their own (TOML-only) diff. Reformat 44 files (~940 ins / 653 del, whitespace only) to clear the backlog so CompatHelper PRs can land.
s-celles
force-pushed
the
compathelper/new_version/2026-05-17-04-01-07-055-01455744853
branch
from
efd1c81 to
b83bd10
Compare
s-celles
added a commit
that referenced
this pull request
May 17, 2026
JSON.jl v1 returns JSON.Object{String,Any} from parsefile, which is
AbstractDict but not Dict. The previous `::Dict` signature dispatched
fine on JSON 0.21 (which returned Dict) but failed with MethodError on
v1. Relaxing to AbstractDict keeps the function working on both — the
inner `attrs isa Dict` guard is widened to `isa AbstractDict` for the
same reason.
Required to land #15 (CompatHelper: bump compat for JSON to 1).
Validated locally: 982/982 tests pass on both JSON 0.21 and 1.6.
s-celles
force-pushed
the
compathelper/new_version/2026-05-17-04-01-07-055-01455744853
branch
from
b83bd10 to
d17bf46
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
s-celles
deleted the
compathelper/new_version/2026-05-17-04-01-07-055-01455744853
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
JSONpackage from0.21to0.21, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.