Repository navigation
fix: return Bool from isequal and isless with missing - #232
Open
jkrumbiegel wants to merge 1 commit into
Open
jkrumbiegel wants to merge 1 commit into
jkrumbiegel wants to merge 1 commit into
Conversation
isequal and isless are total predicates in Base: isequal(x, missing) is false and isless sorts missing last. The disambiguation methods for quantities returned missing for both, like == and <, which broke findfirst(isequal(missing), ...), Dict keys and similar code.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 23 24 +1
Lines 1320 1325 +5
=======================================
+ Hits 1309 1314 +5
Misses 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖:
isequalandislessare supposed to always return aBool(isequal(x, missing)isfalse, andislesssortsmissinglast), but for quantities both returnedmissing:The
missingmethods were added in #35 to resolve Aqua ambiguities, andisequalwas added to the same loop in #85. They all copied the three-valued==behavior, which is only correct for==and<. Nowisequalandislessreturn the same values as Base'sMissingfallbacks.