Use @stackline/fs-write-stream-atomic for VS Code downloads - #686
Open
alexandroit wants to merge 1 commit into
Open
alexandroit wants to merge 1 commit into
alexandroit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selene's VS Code extension imports
fs-write-stream-atomicinselene-vscode/src/util.tsand uses it indownloadSeleneto stream the selected release archive entry to the installed Selene binary with mode0o755.This updates that direct dependency to
@stackline/fs-write-stream-atomic@1.0.0while preserving the historical key:That keeps the existing CommonJS import and local type declaration unchanged. The original
fs-write-stream-atomic@1.0.10package is marked deprecated on npm as no longer supported.Compatibility note
@stackline/fs-write-stream-atomic@1.0.0requires Node>=14.15.1. This is a stricter runtime floor than the legacy package, so runtimes below Node 14.15.1 are not supported by this change. Selene's VS Code workflow currently tests with Node 16.x.Validation
Run with Node 20.20.2 and npm 10.8.2:
npm ci --ignore-scriptsnpm run compile./node_modules/.bin/eslint src/./node_modules/.bin/prettier --check srcnpm ls fs-write-stream-atomic --depth=0resolvedfs-write-stream-atomic@npm:@stackline/fs-write-stream-atomic@1.0.0fs-write-stream-atomic/indexandfs-write-stream-atomic/index.js, then verified the target remains unchanged before commit, is replaced on stream finish, and has no temporary sibling left behindnpm audit --jsonremained unchanged from baseline: 23 findings (2 low, 7 moderate, 12 high, 2 critical)Disclosure: I maintain the Stackline package proposed here.