Repository navigation
basic: use size_t work-item index in constant test - #2852
Open
fzwolinski wants to merge 1 commit into
Open
fzwolinski wants to merge 1 commit into
fzwolinski wants to merge 1 commit into
Conversation
|
|
The constant test sizes its buffers from the device limits, so on a device with a large CL_DEVICE_MAX_CONSTANT_BUFFER_SIZE the number of work-items can exceed INT_MAX. Both kernels stored get_global_id(0) in an int and the host verification loop used an int counter, so indices above INT_MAX wrapped and the test failed even though the results were correct. Use size_t for the work-item index in both kernels and for the verification loop counter. [run-test: test_basic constant] Signed-off-by: Fabian Zwoliński <fabian.zwolinski@intel.com>
rjodinchr
approved these changes
Oct 20, 2026
mmachintel
approved these changes
Oct 20, 2026
bashbaug
approved these changes
Oct 20, 2026
rjodinchr
added
focused review
fast track
svenvh
approved these changes
Oct 21, 2026
joselopeqti
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constant test sizes its buffers from the device limits, so on a
device with a large CL_DEVICE_MAX_CONSTANT_BUFFER_SIZE the number of
work-items can exceed INT_MAX. Both kernels stored get_global_id(0) in
an int and the host verification loop used an int counter, so indices
above INT_MAX wrapped and the test failed even though the results were
correct.
Use size_t for the work-item index in both kernels and for the
verification loop counter.
[run-test: test_basic constant]
Signed-off-by: Fabian Zwoliński fabian.zwolinski@intel.com