Abilities API: Abstract Block Helpers #1099
Open
n7studios wants to merge 3 commits into
Open
Conversation
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
n7studios
requested review from
a team,
ciccio-kit and
noelherrick
and removed request for
a team
ciccio-kit
approved these changes
May 28, 2026
| return $occurrences; | ||
| } | ||
|
|
||
| // Normalise a "no occurrences" result (false) to an empty array. |
There was a problem hiding this comment.
nit (non-blocking): consider moving this normalisation into ConvertKit_Content_Post_Helper::find() itself, so its return narrows from WP_Error|bool|array to WP_Error|array. Any future caller would otherwise need to repeat this check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Abstracts the existing block helpers (
ConvertKit_MCP_Ability_Block_List,ConvertKit_MCP_Ability_Block_Insertetc) to more generic content helpers (ConvertKit_MCP_Ability_Content_List,ConvertKit_MCP_Ability_Content_Insertetc), which use a newConvertKit_Content_Post_Helper.This helper detects whether the page/post being updated needs to use a Kit element (Form, Form Trigger, Broadcasts, Product) block, shortcode or third party element (such as an Elementor widget), depending on how the page/post was created in the first place.
Testing
Existing tests pass.
Checklist