Zekiog verified memory repo shortlist plan#89
Open
Zekiog wants to merge 7 commits into
Open
Conversation
Documents the QuantMind ↔ fincept-ai-ops architecture: - Vector search over quantitative finance literature - MCP tool schema for knowledge queries - Factor library synergy with backtest strategies
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands QuantMind’s “durable loop” direction by introducing governance policy primitives (YAML + runtime helpers), adding an initial hybrid memory engine (L1/L2/L3), and documenting the updated agent-centric positioning with new examples and tests.
Changes:
- Add governance policy schema + loader + enforcement helpers (
quantmind/flows/governance.*) and wire optional tool-allowlist checks intomagic.resolve_magic_input(...). - Introduce initial “mind” layer primitives (
HybridMemoryEngine, L3 commit gates) plus recoverable validation utilities for tolerant ingestion. - Refresh repo docs (README/CONTRIBUTING/architecture) and add tests/examples for the new modules.
Reviewed changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_magic.py | Adds integration tests for resolver-side governance enforcement. |
| tests/mind/test_memory.py | Adds tests for L1/L2 writes and L3 commit gating behavior. |
| tests/mind/init.py | Establishes tests.mind package namespace. |
| tests/flows/test_governance.py | Adds unit tests for governance loader, allowlists, loop budgets, fallback policy, and L3 gates. |
| tests/configs/test_recoverable.py | Adds tests for recoverable validation returning either strict models or fallback nodes. |
| README.md | Repositions project messaging and documents governance/memory direction and usage. |
| quantmind/mind/memory.py | Implements filesystem-backed hybrid memory primitives and L3 commit gates. |
| quantmind/mind/init.py | Exposes mind public API surface. |
| quantmind/magic.py | Adds optional governance parameters and tool allowlist checks to the resolver path. |
| quantmind/flows/governance.yaml | Defines default governance policy (loop budget, fallback, tool allowlists, L3 gates). |
| quantmind/flows/governance.py | Adds governance policy models + loader + enforcement helpers. |
| quantmind/flows/init.py | Re-exports governance helpers from the flows apex package. |
| quantmind/configs/recoverable.py | Adds recoverable validation helper and structured fallback node model. |
| quantmind/configs/init.py | Exports recoverable validation types from the configs surface. |
| quantmind/init.py | Updates package-level description to match agentic workflow focus. |
| examples/mind/recoverable_memory_demo.py | Demonstrates recoverable ingestion and gated memory commit. |
| draft_corrections.md | Adds draft notes for “verified memory repo shortlist” work. |
| docs/fincept_integration.md | Adds Fincept integration guide (currently references non-existent API/CLI). |
| docs/ARCHITECTURE_FOR_NEW_DOMAINS.md | Adds guidance for extending QuantMind beyond the initial paper domain. |
| CONTRIBUTING.md | Updates contributor guidance to match current architecture + verification loop. |
| .impeccable/hook.cache.json | Adds a tool cache artifact (should not be committed). |
| .gitignore | Adds .venv/ ignore (and should also ignore .impeccable/). |
Files not reviewed (1)
- .impeccable/hook.cache.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Please feel free to remove inapplicable items for your PR.
$CATEGORY(xx): xxx(such asfeat(tool): xxx,fix(source): xxx,docs(README): xxx)