RPM: Drop hard-coded Vendor tag#118
Open
mavit wants to merge 2 commits into
Open
Conversation
This should be set in the build environment (see accompanying commit to `slimserver` repository) rather than in the `.spec` file, so that if someone builds the RPM on their local machine, say, it doesn’t look like an official build. Signed-off-by: Peter Oliver <git@mavit.org.uk>
The URL is in the URL tag, so we don’t need it in the Packager tag too. Signed-off-by: Peter Oliver <git@mavit.org.uk>
Contributor
Author
|
Requires LMS-Community/slimserver#1608 |
|
|
||
| Name: %{src_basename} | ||
| Packager: Lyrion Community - please visit www.lyrion.org | ||
| Packager: Lyrion Community |
Member
There was a problem hiding this comment.
Why would you leave this in, but not the Vendor value? Just asking...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be set in the build environment (see accompanying commit to
slimserverrepository) rather than in the.specfile, so that if someone builds the RPM on their local machine, say, it doesn’t look like an official build.While we’re here, drop the redundant URL from Packager tag. The URL is in the URL tag, so we don’t need it in the Packager tag too.