fix(tooling): queue self-updates and stop tests leaking temp files - #62
Merged
Merged
Conversation
In a repository with a merge queue, the update asked for a rebase auto-merge, which GitHub records but never adds to the queue, so transit-mapper's patch updates waited for someone to queue them. The update now leaves the method to the queue when the default branch has one. The commit-hook and contribution-helper tests also created temporary directories they never removed; hundreds had piled up. Each file now keeps them under one root that is deleted after its tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Publish merge-queue support for self-updates as a patch release of the shared web standard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
transit-mapper's patch updates now merge themselves like every other repository's, and the test suite no longer leaves temporary directories behind.
Overview of Changes
Merge queue
transit-mapper merges through a merge queue. The
Standard updateworkflow asked for a rebase auto-merge, which GitHub records on a merge-queue repository but never adds to the queue, so transit-mapper#170 sat green until I queued it by hand. The workflow now reads the default branch's rules and, when a merge queue is one of them, turns on auto-merge without naming a method, which puts the pull request in the queue.Temporary directories
The commit-hook and contribution-helper tests created temporary directories and never removed them; several hundred had piled up on a development machine. Each of those files now creates one root at load, puts every temporary directory under it, and removes it after its tests. Running them now leaves nothing behind.
Testing
`pnpm check` passes. A new proposal test shows a merge-queue repository gets
gh pr merge --autowith no method, and the existing ones cover a repository without a queue.Follow-ups
None.
🤖 Generated with Claude Code