💭 fix: Show the Thoughts Floating Bar Only When Its Header Is Off Screen - #16642
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
0e1bad4 to
623f96d
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
623f96d to
95f3bcd
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
3fb8046 to
d809663
Compare
d809663 to
5536259
Compare
…ader Is Off Screen
5536259 to
02b5f7e
Compare
Summary
Part 3 of the ui-refinments stack (#16640 onto dev, then #16641, #16642, #16643; merge from the bottom up).
The Thoughts block showed its floating collapse and copy bar even while the Thoughts header was plainly on screen, because the bar trusted the last IntersectionObserver entry, and an entry recorded while the block was still opening could arrive after it settled and claim the header was hidden. The bar now re-measures the header's real position, clipped against the viewport and every scrolling ancestor, on each observer notification and whenever the pointer or focus reveals the bar, so it appears only once the header has scrolled away.
Pressing and holding the Thoughts header no longer flashes a background, and the block drops the extra bottom padding it reserved for the bar.
Type of change
Testing
Tested environments/configuration:
Automated tests:
npx jest --findRelatedTestson the changed filesnpx tsc --noEmit -p client/tsconfig.json, ESLint, Prettier,npm run static-checksScreenshots / recordings
Captured from the e2e mock harness at 1280x800 against the client built before and after this PR.
Risk / compatibility
None.
Checklist