Skip to content

💭 fix: Show the Thoughts Floating Bar Only When Its Header Is Off Screen - #16642

Merged
berry-13 merged 5 commits into
devfrom
berry-13/thoughts-floating-bar
Oct 2, 2026
Merged

berry-13 merged 5 commits into
devfrom
berry-13/thoughts-floating-bar

Conversation

@berry-13

@berry-13 berry-13 commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Part 3 of the ui-refinments stack (#16640 onto dev, then #16641, #16642, #16643; merge from the bottom up).

The Thoughts block showed its floating collapse and copy bar even while the Thoughts header was plainly on screen, because the bar trusted the last IntersectionObserver entry, and an entry recorded while the block was still opening could arrive after it settled and claim the header was hidden. The bar now re-measures the header's real position, clipped against the viewport and every scrolling ancestor, on each observer notification and whenever the pointer or focus reveals the bar, so it appears only once the header has scrolled away.

Pressing and holding the Thoughts header no longer flashes a background, and the block drops the extra bottom padding it reserved for the bar.

Type of change

  • Bug fix

Testing

Tested environments/configuration:

  • Browser: Chromium (Playwright) against a local dev server, light and dark mode
  • Opened Thoughts in the first and second reply with the pointer resting on the header, then hovered the body and moved out and back: the bar stayed hidden in every case

Automated tests:

  • npx jest --findRelatedTests on the changed files
  • npx tsc --noEmit -p client/tsconfig.json, ESLint, Prettier, npm run static-checks

Screenshots / recordings

Captured from the e2e mock harness at 1280x800 against the client built before and after this PR.

Before After
Open Thoughts, pointer over the body, light Before After
Header held down, light Before After
Open Thoughts, pointer over the body, dark Before After
Header held down, dark Before After

Risk / compatibility

None.

Checklist

  • I reviewed my own changes
  • Existing relevant tests pass
  • The change does not introduce new warnings or errors

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T21:17:09.079293Z 02b5f7e New commits
🔒 Security Review ✅ Completed 2026-10-01T22:21:16.719323Z 0e1bad4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@berry-13
berry-13 added this pull request to stack #16644 October 1, 2026 22:19
@codegraph-librechat codegraph-librechat Bot added the 🗺️ Agent Chat UI codegraph: the taxonomy area this belongs to (classifier, confidence ≥ 0.9) label Oct 1, 2026
Copilot AI balanced review requested due to automatic review settings October 2, 2026 14:27
@berry-13
berry-13 force-pushed the berry-13/thoughts-floating-bar branch from 0e1bad4 to 623f96d Compare October 2, 2026 14:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@berry-13
berry-13 force-pushed the berry-13/thoughts-floating-bar branch from 623f96d to 95f3bcd Compare October 2, 2026 16:01
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@berry-13
berry-13 force-pushed the berry-13/thoughts-floating-bar branch 2 times, most recently from 3fb8046 to d809663 Compare October 2, 2026 17:37
@berry-13
berry-13 force-pushed the berry-13/thoughts-floating-bar branch from d809663 to 5536259 Compare October 2, 2026 20:47
Base automatically changed from berry-13/ask-question-refine to dev October 2, 2026 21:14
@berry-13
berry-13 force-pushed the berry-13/thoughts-floating-bar branch from 5536259 to 02b5f7e Compare October 2, 2026 21:14
@berry-13
berry-13 merged commit da2bc05 into dev Oct 2, 2026
29 checks passed
@berry-13
berry-13 deleted the berry-13/thoughts-floating-bar branch October 2, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗺️ Agent Chat UI codegraph: the taxonomy area this belongs to (classifier, confidence ≥ 0.9)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants