New landing page configuration - #4606
Draft
ildyria wants to merge 7 commits into
Draft
Conversation
Rewrite spec/plan/tasks for the configurable landing page feature to document all resolved architecture questions (Q-054-01..19) as full Decision Cards per spec-guidelines/open-questions-format.md, instead of loose prose. Q-054-01..10 cover the original design decisions (layout architecture, v8-only scope, SE gating, admin UI approach, dropped custom-CSS field, Mod Welcome category absorption, automatic+manual featured content, free-text link icons). Q-054-11..19 are gaps found during review and fixed directly: - landing_show_stats corrected to portfolio-only (was inconsistent) - confirmed the Featured tab's Search-based picker already surfaces private content to admin sessions (may_administrate bypass) - SE-gated dropdown options decided as badged-but-selectable, always showing the stored (not effective) config value - documented the intentional FR-054-26/S-054-27 numbering gap - clarified route registration needs both router/paths.ts and resources/js/v8/router/routes.ts - pinned the Mod Welcome filter citation to SettingsController.php:83 - designed the previously unspecified Reorder endpoint contract from scratch (no precedent existed anywhere in this codebase) - added missing icon length validation - confirmed studio's secondary CTA label is deliberately fixed open-questions.md rows updated to cross-reference the cards' option lettering; roadmap.md and _current-session.md updated accordingly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.