Repository navigation
fix(agent-sessions): ingest detection and attribute decoding - #1127
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Sep 28, 2026 in 5m 44s
Confidence 4/5 · No issues found
Confidence 4/5 · likely safe to merge
The one place to watch is the merge-order gate: without #1121 the reclassified OpenInference OpenAI-Agents spans decode through the default GenAI integration.
quality 98/100 · 1 note · tests covered · risk medium
The head commit narrows the custom-service Strands rule in apps/ingest/src/ai_session.rs to spans carrying gen_ai.event.start_time, closing the false-positive the bot raised on service-named scopes. The ai_session.rs delta reads correctly and is covered by tests; safe to merge, gated on #1121 per the PR body.
detect_strandsneedsgen_ai.event.start_timefor the service-named TS rulegen_ai_event_start_timeevidence bit set fromgen_ai.event.start_time- Two tests cover the positive and the negative Strands cases
Still open from earlier reviews
- Note · F1 ·
anyValueJsonemits map keys in insertion order, Rust sorts them ·apps/cli/src/server/otlp/encode.ts:262
What was checked
- Both new scope names are in
SCOPE_NAMES(ai_session.rs:291), so the two-byte scope screen admits them matches_service_namecannot fire on an emptyservice.name;scope_factsreturns early for an empty scope (ai_session.rs:308)- No new entrypoint, outbound call, log or metric in the delta; observability coverage is empty
5f8fa10 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple to ask about one.
Loading