Skip to content

fix(agent-sessions): ingest detection and attribute decoding - #1127

Merged
JeremyFunk merged 10 commits into
mainfrom
fix/agent-sessions-ingest-detection
Sep 29, 2026
Merged

JeremyFunk merged 10 commits into
mainfrom
fix/agent-sessions-ingest-detection

fix(agent-sessions): require the Strands event-time key for the custo…

5f8fa10
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Sep 28, 2026 in 5m 44s

Confidence 4/5 · No issues found

Confidence 4/5 · likely safe to merge
The one place to watch is the merge-order gate: without #1121 the reclassified OpenInference OpenAI-Agents spans decode through the default GenAI integration.
quality 98/100 · 1 note · tests covered · risk medium

The head commit narrows the custom-service Strands rule in apps/ingest/src/ai_session.rs to spans carrying gen_ai.event.start_time, closing the false-positive the bot raised on service-named scopes. The ai_session.rs delta reads correctly and is covered by tests; safe to merge, gated on #1121 per the PR body.

  • detect_strands needs gen_ai.event.start_time for the service-named TS rule
  • gen_ai_event_start_time evidence bit set from gen_ai.event.start_time
  • Two tests cover the positive and the negative Strands cases

Still open from earlier reviews

What was checked
  • Both new scope names are in SCOPE_NAMES (ai_session.rs:291), so the two-byte scope screen admits them
  • matches_service_name cannot fire on an empty service.name; scope_facts returns early for an empty scope (ai_session.rs:308)
  • No new entrypoint, outbound call, log or metric in the delta; observability coverage is empty

5f8fa10 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple to ask about one.