MDEV-23278: Incorrect Calculation with AVG() Function#5009
Open
DaveGosselin-MariaDB wants to merge 1 commit into10.11from
Open
MDEV-23278: Incorrect Calculation with AVG() Function#5009DaveGosselin-MariaDB wants to merge 1 commit into10.11from
DaveGosselin-MariaDB wants to merge 1 commit into10.11from
Conversation
Type_handler_int_result::Item_decimal_precision assumes that max_length includes space for a sign, but Item_int literals don't include such a space. When aggregate_attributes_int propagates these into functions via a Item_type_holder, the formula computes precision-1 (or 0 for 1-digit cases), producing the incorrect calculation with AVG. This fix changes aggregate_attributes_int to follow the convention the Type_handler expects, that max_length = max digit-count + (signed ? 1 : 0). This matches the TODO comment that begins with "TODO: rewrite aggregate_attributes_int()... " which suggested this idea.
DaveGosselin-MariaDB
force-pushed
the
10.11-MDEV-23278-incorrect-avg-result
branch
from
555d629 to
2c3f8ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type_handler_int_result::Item_decimal_precision assumes that max_length includes space for a sign, but Item_int literals don't include such a space. When aggregate_attributes_int propagates these into functions via a Item_type_holder, the formula computes precision-1 (or 0 for 1-digit cases), producing the incorrect calculation with AVG.
This fix changes aggregate_attributes_int to follow the convention the Type_handler expects, that max_length = max digit-count + (signed ? 1 : 0). This matches the TODO comment that begins with "TODO: rewrite aggregate_attributes_int()... " which suggested this idea.