Skip to content

ci: disable RDS automated backups in the temporary Terraform test roots #38741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobbyiliev merged 1 commit into from
Sep 10, 2026
+12 −0
Merged

ci: disable RDS automated backups in the temporary Terraform test roots #38741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/terraform/aws-temporary/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,12 @@ module "database" {
node_security_group_id = module.eks.node_security_group_id
tags = var.tags

# A throwaway test database needs no point-in-time recovery, and the module
# default of 7 days makes every teardown wait on deleting a week of automated
# backups: nightly 18272's destroy was still on the RDS instance after 55
# minutes against a 90 minute step budget.
backup_retention_period = 0

depends_on = [
module.eks,
module.networking,
Expand Down
6 changes: 6 additions & 0 deletions test/terraform/aws-upgrade/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,12 @@ module "database" {
node_security_group_id = module.eks.node_security_group_id
tags = var.tags

# A throwaway test database needs no point-in-time recovery, and the module
# default of 7 days makes every teardown wait on deleting a week of automated
# backups: nightly 18272's destroy was still on the RDS instance after 55
# minutes against a 90 minute step budget.
backup_retention_period = 0

depends_on = [
module.eks,
module.networking,
Expand Down
Loading