Bugfix/bitwise ops sometimes return negatives - #49

Open

quetzalcoatl wants to merge 7 commits into

MattyIce:masterfrom

quetzalcoatl:bugfix/bitwise-ops-sometimes-return-negatives

Commits on Oct 24, 2018

added bunch of tests that show that and64/or64/shift64 are unsafe for large numbers that may be treated as signed
quetzalcoatl
committed
76cd9f4
forced and64/or64 result to be unsigned
quetzalcoatl
committed
9d31391
corrected and simplified both shift64, added truncation to shiftleft64 to ensure it returns integer not longer than 64bit
quetzalcoatl
committed
d7334df
refactor/cleanup: no need to recalculate true constants
quetzalcoatl
committed
d025b2a
refactor/cleanup: added 'var' to limit scope of some variables, just in case
quetzalcoatl
committed
00d0452
improved sqrt's sanity check, our approx algo is NOT safe for negatives
quetzalcoatl
committed
1a16452
added note how to run these tests
quetzalcoatl
committed
ac72109