Skip to content

Test: check that the API is fully represented in the dropdowns - #1254

Merged
Daetha merged 2 commits into
devfrom
fix/issue-1244
Oct 6, 2026
Merged

Daetha merged 2 commits into
devfrom
fix/issue-1244

Conversation

@Daetha

@Daetha Daetha commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

This test completely solves the issue #1244

Changes

I have added a test to ensure the API responses end up in dropdowns.

Notes for Reviewer

Not much to review. To test run:
npx playwright test --debug --headed --project=generic formgroups/contributor-role-dropdowns.spec.ts

Checklist

Branching Strategy:

If this is a hotfix: The branch was created from main and will be merged into main.
If this is a feature or documentation change: The branch was created from dev and will be merged into dev.
If this is a feature or documentation branch, I have pulled the latest changes from main into my branch.

Code Quality

  • My code follows the style guide.
  • I have self-reviewed my code.
  • I added comments for hard-to-understand code.
  • My changes do not create new warnings in the browser console.

Documentation

  • If applicable, PHP code is documented using PHPDoc.
  • If applicable, JavaScript code is documented using JSDoc.
  • If needed, the ELMO Guide ('./doc/help.html') has been updated.
  • If needed, the README has been updated.
  • If needed, the API documentation ('./api/v2/docs') has been updated.
  • If a new feature was added or a bug fixed, the changelog ('./doc/changelog.html') has been updated.

Testing

  • If needed, Playwright tests have been updated or added.
  • If needed, unit tests have been updated or added.
  • If needed, jest tests have been updated or added.

Known Issues

[What lower priority problems remain?]

@Daetha Daetha added this to the v2.2.0 milestone Oct 5, 2026
@Daetha Daetha self-assigned this Oct 5, 2026
@Daetha
Daetha changed the base branch from main to dev October 5, 2026 09:24

@McNamara84 McNamara84 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding test coverage is always a good idea. Test is working on local machine and (off course) in CI. Approved.

Best,
Holger

@Daetha
Daetha merged commit 504fa2b into dev Oct 6, 2026
11 checks passed
@Daetha
Daetha deleted the fix/issue-1244 branch October 6, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants