Fix opening GUI outside of worlds#6386
Merged
Big-Iron-Cheems merged 11 commits intoMeteorDevelopment:masterfrom May 9, 2026
Merged
Fix opening GUI outside of worlds#6386Big-Iron-Cheems merged 11 commits intoMeteorDevelopment:masterfrom
Big-Iron-Cheems merged 11 commits intoMeteorDevelopment:masterfrom
Conversation
Potions uhhhhhhhhhhh
Don't need anything but the color
Contributor
|
related issue may be this one |
Contributor
Author
|
Actually yea that is related I am simply blind :3 thanks |
Big-Iron-Cheems
approved these changes
May 7, 2026
elijah-yum
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
In 26.1 Itemstacks now require components to be loaded from registry entries that are only provided when we join a world, however since we only need a few specific components that are stored client-side we can simply construct our own stacks for rendering that contain only those.
Implemented utils/DisplayItemUtils which creates these stacks and replaced all getDefaultInstance() calls in rendering contexts with DisplayItemUtils#toStack(Item item)
Breaking for addons, any addon that defines category icons will need to do so using the new util as well or NPE
Also added a few placeholder items in inventoryhud that show while outside of a world
Related issues
#6361
How Has This Been Tested?
8mb.video-3Zp-cu0PskvZ.mp4
Checklist: